CI / Build & test (Node 20) (push) Canceled after 0s
CI / Build & test (Node 24) (push) Canceled after 0s
CI / Build & test (push) Canceled after 0s
CodeQL / Analyze (javascript-typescript) (push) Canceled after 0s
Security / Secret scan (gitleaks) (push) Canceled after 0s
Security / Dependency scan (OSV-Scanner) (push) Canceled after 0s
Security / IaC/config scan (Trivy) (push) Canceled after 0s
Security / License compliance scan (Trivy) (push) Canceled after 0s
OpenSSF Scorecard / Scorecard analysis (push) Canceled after 0s
Ordered by what the group hits, not by string count.
- Chat system messages ("X added Y to the group") and their sidebar
preview twin. These are content, not chrome, so they sat in English in
the middle of conversations.
- Login, register and the invite landing page — the first screen anyone
invited to the instance sees.
- Voice — controls, connection info, the mobile join sheet, settings tab.
- Mobile screens.
- Settings navigation across space, user and instance, plus Discovery and
join requests.
Three call sites build strings outside a component and so read the locale
directly rather than through the hook: the sidebar preview formatter, the
connection-info track labels, and MobileShell's screen map — which holds
plain functions that are *called*, not rendered, where a hook would run
under whichever component invoked the map. Each says so at the definition;
all three re-render often enough that a language switch shows through
promptly.
Adds a test for a mistake made three times in this series: a file with an
exported component plus a private sub-component, where only the exported one
got the hook. tsc catches it, but only after a full build and without naming
the component. The test names it, and also flags the inverse — a hook placed
below an early return, which tsc accepts and React breaks at runtime (this
project shipped that once, as error #310). Verified by mutation: removing a
hook makes it fail and print the component.
Dictionary is at 856 keys, en and pt-BR at exact parity.
Verified: web build (tsc + vite), 492 web tests.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
101 lines
3.5 KiB
TypeScript
101 lines
3.5 KiB
TypeScript
import type { DmChannel, MessageWithUser, SpaceInviteSystemPayload, User } from '@backspace/shared';
|
|
import { SpaceInviteCard } from './SpaceInviteCard';
|
|
import { useT } from '../../i18n';
|
|
|
|
interface SystemMessageProps {
|
|
message: MessageWithUser;
|
|
/**
|
|
* The enclosing DM channel, if the message belongs to one. Used to resolve
|
|
* the actor's display name from the channel roster (`dm.members`) for events
|
|
* that don't carry it in the payload (e.g. `name_changed`, `icon_changed`,
|
|
* `owner_changed`). When omitted (e.g. server channels), the renderer falls
|
|
* back to the embedded `message.user`.
|
|
*/
|
|
dm?: Pick<DmChannel, 'members'> | null;
|
|
}
|
|
|
|
function resolveActorName(
|
|
message: MessageWithUser,
|
|
dm: Pick<DmChannel, 'members'> | null | undefined,
|
|
unknown: string,
|
|
someone: string,
|
|
): string {
|
|
if (dm) {
|
|
const fromRoster = dm.members.find(m => m.id === message.userId) as User | undefined;
|
|
if (fromRoster) {
|
|
return fromRoster.displayName ?? fromRoster.username ?? unknown;
|
|
}
|
|
return unknown;
|
|
}
|
|
return message.user?.displayName ?? message.user?.username ?? someone;
|
|
}
|
|
|
|
/**
|
|
* Inline timeline renderer for system DM messages. Mirrors the sidebar's
|
|
* `formatSystemPreview` semantics but with icons + a slightly fuller phrasing
|
|
* (e.g. surfacing the new name in `name_changed`).
|
|
*
|
|
* Exported so unit tests can render it directly without mounting MessageList.
|
|
*/
|
|
export function SystemMessage({ message, dm }: SystemMessageProps) {
|
|
const t = useT();
|
|
let data: Record<string, unknown> = {};
|
|
try { data = JSON.parse(message.content ?? '{}'); } catch { /* fall through to default branch */ }
|
|
|
|
const actorName = resolveActorName(message, dm, t('system.unknown'), t('system.someone'));
|
|
|
|
if (data.event === 'space_invite') {
|
|
return (
|
|
<div className="px-4 py-1">
|
|
<SpaceInviteCard payload={data as unknown as SpaceInviteSystemPayload} senderName={actorName} />
|
|
</div>
|
|
);
|
|
}
|
|
|
|
// Inline-text events.
|
|
let text = '';
|
|
let icon = '';
|
|
switch (data.event) {
|
|
case 'member_added':
|
|
icon = '→'; // →
|
|
text = t('system.memberAdded', { actor: actorName, target: String(data.targetDisplayName) });
|
|
break;
|
|
case 'member_removed':
|
|
if (data.reason === 'leave') {
|
|
icon = '←'; // ←
|
|
text = t('system.memberLeft', { target: String(data.targetDisplayName) });
|
|
} else {
|
|
icon = '←';
|
|
text = t('system.memberRemoved', { actor: actorName, target: String(data.targetDisplayName) });
|
|
}
|
|
break;
|
|
case 'owner_changed':
|
|
icon = '♛'; // ♛
|
|
text = t('system.ownerChanged', { owner: String(data.newOwnerDisplayName) });
|
|
break;
|
|
case 'name_changed':
|
|
icon = '✎'; // ✎
|
|
// newName === null is a meaningful "cleared" state — distinct from a
|
|
// missing field — so we test for a non-empty string explicitly.
|
|
text = typeof data.newName === 'string' && data.newName.length > 0
|
|
? t('system.nameChanged', { actor: actorName, name: data.newName })
|
|
: t('system.nameCleared', { actor: actorName });
|
|
break;
|
|
case 'icon_changed':
|
|
icon = '\u{1F5BC}'; // 🖼
|
|
text = t('system.iconChanged', { actor: actorName });
|
|
break;
|
|
default:
|
|
text = message.content ?? '';
|
|
}
|
|
|
|
return (
|
|
<div className="flex items-center justify-center py-1 px-4 select-none">
|
|
<span className="text-xs text-txt-tertiary">
|
|
<span className="mr-1.5">{icon}</span>
|
|
{text}
|
|
</span>
|
|
</div>
|
|
);
|
|
}
|