devsyncwrld/backspace
1
0
Fork 0
Code Issues Pull Requests Actions 35 Packages Projects Releases Wiki Activity

refactor(server): remove unused admin_reset PeerDeactivationReason

Browse Source 
The admin reset endpoint (DELETE-pattern gated on peer.status !== 'needs_attention')
doesn't transition status — it deletes the row of an already-deactivated peer.
onPeerDeactivated already fired at the earlier needs_attention transition, so
the reset site correctly has no hook. The enum value was defensive-unused; per
project principles (no backwards-compat shims, no placeholders) drop it.
This commit is contained in:
Jannis Braun
2026-04-24 01:07:47 +02:00
parent 7c0dd33123
commit 5c94bc7669
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/server/src/utils/federationPeerActivation.ts
+1 -2
View File
@@ -196,8 +196,7 @@ export type PeerDeactivationReason =
| 'network_threshold' // outbox worker hit PEER_UNREACHABLE_THRESHOLD | 'network_threshold' // outbox worker hit PEER_UNREACHABLE_THRESHOLD
| 'auth_threshold' // outbox worker hit AUTH_FAILURE_THRESHOLD | 'auth_threshold' // outbox worker hit AUTH_FAILURE_THRESHOLD
| 'remote_rejected' // auto-peer handshake got 403 PEERING_REQUIRES_APPROVAL | 'remote_rejected' // auto-peer handshake got 403 PEERING_REQUIRES_APPROVAL
| 'admin_revoked' // admin revoked peering from this side | 'admin_revoked'; // admin revoked peering from this side
| 'admin_reset'; // admin reset peer clearing to non-active status
// Dedup: concurrent deactivations for the same peerId share one promise. // Dedup: concurrent deactivations for the same peerId share one promise.
// SEPARATE from inFlightActivation — a flapping peer's activate-then-deactivate // SEPARATE from inFlightActivation — a flapping peer's activate-then-deactivate