From 5c94bc766971dc789dcf015d7a4376b792d2e606 Mon Sep 17 00:00:00 2001 From: Jannis Braun <151788261+TheZwiss@users.noreply.github.com> Date: Fri, 24 Apr 2026 01:07:47 +0200 Subject: [PATCH] refactor(server): remove unused admin_reset PeerDeactivationReason MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The admin reset endpoint (DELETE-pattern gated on peer.status !== 'needs_attention') doesn't transition status — it deletes the row of an already-deactivated peer. onPeerDeactivated already fired at the earlier needs_attention transition, so the reset site correctly has no hook. The enum value was defensive-unused; per project principles (no backwards-compat shims, no placeholders) drop it. --- packages/server/src/utils/federationPeerActivation.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/packages/server/src/utils/federationPeerActivation.ts b/packages/server/src/utils/federationPeerActivation.ts index e2f981f2..a290bc0d 100644 --- a/packages/server/src/utils/federationPeerActivation.ts +++ b/packages/server/src/utils/federationPeerActivation.ts @@ -196,8 +196,7 @@ export type PeerDeactivationReason = | 'network_threshold' // outbox worker hit PEER_UNREACHABLE_THRESHOLD | 'auth_threshold' // outbox worker hit AUTH_FAILURE_THRESHOLD | 'remote_rejected' // auto-peer handshake got 403 PEERING_REQUIRES_APPROVAL - | 'admin_revoked' // admin revoked peering from this side - | 'admin_reset'; // admin reset peer clearing to non-active status + | 'admin_revoked'; // admin revoked peering from this side // Dedup: concurrent deactivations for the same peerId share one promise. // SEPARATE from inFlightActivation — a flapping peer's activate-then-deactivate