Jannis Braun
aef15a7cf7
The redirect effect used the shared `channels` array which could contain stale data from a previously viewed server during async loadServerDetail. Added channelToServerMap ownership check to ensure channels belong to the target server before redirecting. Also persists last-visited channel per server in localStorage for better return navigation.
305 lines
11 KiB
TypeScript
305 lines
11 KiB
TypeScript
import React, { useEffect } from 'react';
|
|
import { useParams, useNavigate } from 'react-router-dom';
|
|
import { ServerSidebar } from './ServerSidebar';
|
|
import { ChannelSidebar } from './ChannelSidebar';
|
|
import { MainContent } from './MainContent';
|
|
import { RightPanel } from './RightPanel';
|
|
import { MobileNav } from './MobileNav';
|
|
import { ImagePreview } from '../chat/ImagePreview';
|
|
import { CreateServerModal } from '../modals/CreateServer';
|
|
import { JoinServerModal } from '../modals/JoinServer';
|
|
import { CreateChannelModal } from '../modals/CreateChannel';
|
|
import { InviteModal } from '../modals/InviteModal';
|
|
import { UserSettingsModal } from '../modals/UserSettings';
|
|
import { ServerSettingsModal } from '../modals/ServerSettings';
|
|
import { ChannelSettingsModal } from '../modals/ChannelSettingsModal';
|
|
import { NewDmModal } from '../modals/NewDmModal';
|
|
import { AddDmMemberModal } from '../modals/AddDmMemberModal';
|
|
import { IncomingCallModal } from '../voice/IncomingCallModal';
|
|
import { PictureInPicture } from '../voice/PictureInPicture';
|
|
import { SoundController } from '../voice/SoundController';
|
|
import { GlobalAudioRenderer } from '../voice/GlobalAudioRenderer';
|
|
import { UserProfilePopout } from '../ui/UserProfilePopout';
|
|
import { ToastContainer } from '../ui/ToastContainer';
|
|
import { useAuth } from '../../hooks/useAuth';
|
|
import { useWebSocket } from '../../hooks/useWebSocket';
|
|
import { useFederationToasts } from '../../hooks/useFederationToasts';
|
|
import { useLiveKit } from '../../hooks/useLiveKit';
|
|
import { useServerStore } from '../../stores/serverStore';
|
|
import { useChatStore } from '../../stores/chatStore';
|
|
import { useUIStore } from '../../stores/uiStore';
|
|
import { useVoiceStore } from '../../stores/voiceStore';
|
|
import { AudioManager } from '../../audio/AudioManager';
|
|
|
|
export function AppLayout() {
|
|
const { serverId, channelId, inviteCode } = useParams<{ serverId?: string; channelId?: string; inviteCode?: string }>();
|
|
const navigate = useNavigate();
|
|
|
|
// Global interaction handler to resume AudioContext
|
|
useEffect(() => {
|
|
const resume = () => {
|
|
AudioManager.getInstance().resumeContext().then(() => {
|
|
window.removeEventListener('click', resume);
|
|
window.removeEventListener('keydown', resume);
|
|
window.removeEventListener('touchstart', resume);
|
|
});
|
|
};
|
|
window.addEventListener('click', resume);
|
|
window.addEventListener('keydown', resume);
|
|
window.addEventListener('touchstart', resume);
|
|
return () => {
|
|
window.removeEventListener('click', resume);
|
|
window.removeEventListener('keydown', resume);
|
|
window.removeEventListener('touchstart', resume);
|
|
};
|
|
}, []);
|
|
|
|
// MutationObserver: neutralize rogue LiveKit <audio> elements that bypass our Web Audio pipeline.
|
|
// LiveKit can re-attach hidden <audio> elements after .detach(), causing full-volume playback
|
|
// that ignores our volume/mute controls. Any <audio> without data-backspace is immediately killed.
|
|
useEffect(() => {
|
|
const observer = new MutationObserver((mutations) => {
|
|
for (const mutation of mutations) {
|
|
mutation.addedNodes.forEach((node) => {
|
|
if (node instanceof HTMLAudioElement && !node.dataset.backspace) {
|
|
node.muted = true;
|
|
node.volume = 0;
|
|
node.pause();
|
|
node.srcObject = null;
|
|
}
|
|
});
|
|
}
|
|
});
|
|
observer.observe(document.body, { childList: true, subtree: true });
|
|
return () => observer.disconnect();
|
|
}, []);
|
|
|
|
// Sync persisted output device preference to AudioManager.
|
|
// AudioManager defers setSinkId until the AudioContext is actually created,
|
|
// so this is safe to call before any user interaction.
|
|
const outputDeviceId = useVoiceStore((s) => s.outputDeviceId);
|
|
useEffect(() => {
|
|
AudioManager.getInstance().setOutputDevice(outputDeviceId);
|
|
}, [outputDeviceId]);
|
|
|
|
const { user, isLoading } = useAuth();
|
|
const setCurrentServer = useServerStore((s) => s.setCurrentServer);
|
|
const loadServerDetail = useServerStore((s) => s.loadServerDetail);
|
|
const setCurrentChannel = useChatStore((s) => s.setCurrentChannel);
|
|
const loadMessages = useChatStore((s) => s.loadMessages);
|
|
const setIsMobile = useUIStore((s) => s.setIsMobile);
|
|
const setShowDms = useUIStore((s) => s.setShowDms);
|
|
const openModal = useUIStore((s) => s.openModal);
|
|
|
|
const sidebarOpen = useUIStore((s) => s.sidebarOpen);
|
|
const isMobile = useUIStore((s) => s.isMobile);
|
|
const userProfilePopout = useUIStore((s) => s.userProfilePopout);
|
|
const closeUserProfile = useUIStore((s) => s.closeUserProfile);
|
|
|
|
const channels = useServerStore((s) => s.channels);
|
|
|
|
const currentVoiceChannelId = useVoiceStore((s) => s.currentVoiceChannelId);
|
|
const activeDmCall = useVoiceStore((s) => s.activeDmCall);
|
|
const {
|
|
connect: connectVoice,
|
|
disconnect: disconnectVoice,
|
|
isConnected: isVoiceConnected,
|
|
isConnecting: isVoiceConnecting,
|
|
connectedChannelId,
|
|
} = useLiveKit();
|
|
|
|
// Initialize WebSocket
|
|
const { isConnected: isWsConnected } = useWebSocket();
|
|
|
|
// Federation toast notifications for remote instance connection state changes
|
|
useFederationToasts();
|
|
|
|
// Track the last channel we attempted to connect to, to prevent effect loops
|
|
const lastAttemptedRef = React.useRef<string | null>(null);
|
|
|
|
// Manage voice connection
|
|
useEffect(() => {
|
|
if (isLoading || !user || !isWsConnected) return;
|
|
|
|
const manageConnection = async () => {
|
|
// Determine what we SHOULD be connected to
|
|
const targetChannelId = activeDmCall
|
|
? `dm-${activeDmCall.dmChannelId}`
|
|
: currentVoiceChannelId;
|
|
|
|
// 1. If we have a target
|
|
if (targetChannelId) {
|
|
// If we're not connected to the RIGHT place, trigger connect.
|
|
// We IGNORE isVoiceConnecting here to allow "interrupting" a connection
|
|
// or switching rooms immediately.
|
|
if (connectedChannelId !== targetChannelId) {
|
|
// Prevent spamming the same connection attempt if React re-renders
|
|
if (lastAttemptedRef.current === targetChannelId && isVoiceConnecting) {
|
|
return;
|
|
}
|
|
|
|
console.log(`[AppLayout] Switching/Connecting to: ${targetChannelId}`);
|
|
lastAttemptedRef.current = targetChannelId;
|
|
|
|
if (activeDmCall) {
|
|
await connectVoice(activeDmCall.dmChannelId, true);
|
|
} else {
|
|
await connectVoice(targetChannelId);
|
|
}
|
|
} else {
|
|
// We are connected to the right place. Reset ref.
|
|
lastAttemptedRef.current = null;
|
|
}
|
|
return;
|
|
}
|
|
|
|
// 2. No target — ensure disconnected
|
|
if (connectedChannelId !== null || isVoiceConnected || isVoiceConnecting) {
|
|
console.log('[AppLayout] Leaving voice (no target)');
|
|
lastAttemptedRef.current = null;
|
|
await disconnectVoice();
|
|
}
|
|
};
|
|
|
|
manageConnection();
|
|
}, [
|
|
currentVoiceChannelId,
|
|
activeDmCall,
|
|
connectedChannelId,
|
|
isVoiceConnected,
|
|
isVoiceConnecting,
|
|
isWsConnected,
|
|
isLoading,
|
|
user,
|
|
connectVoice,
|
|
disconnectVoice
|
|
]);
|
|
|
|
// Responsive detection
|
|
useEffect(() => {
|
|
const checkMobile = () => setIsMobile(window.innerWidth < 768);
|
|
checkMobile();
|
|
window.addEventListener('resize', checkMobile);
|
|
return () => window.removeEventListener('resize', checkMobile);
|
|
}, [setIsMobile]);
|
|
|
|
// Handle route params
|
|
useEffect(() => {
|
|
if (serverId === '@me') {
|
|
setShowDms(true);
|
|
setCurrentServer(null);
|
|
} else if (serverId) {
|
|
setShowDms(false);
|
|
setCurrentServer(serverId);
|
|
loadServerDetail(serverId);
|
|
} else {
|
|
setShowDms(false);
|
|
setCurrentServer(null);
|
|
}
|
|
}, [serverId, setCurrentServer, loadServerDetail, setShowDms]);
|
|
|
|
useEffect(() => {
|
|
if (inviteCode) {
|
|
openModal('joinServer');
|
|
}
|
|
}, [inviteCode, openModal]);
|
|
|
|
useEffect(() => {
|
|
if (channelId) {
|
|
setCurrentChannel(channelId);
|
|
loadMessages(channelId);
|
|
if (serverId && serverId !== '@me') {
|
|
useUIStore.getState().setLastChannel(serverId, channelId);
|
|
}
|
|
} else {
|
|
setCurrentChannel(null);
|
|
}
|
|
}, [channelId, serverId, setCurrentChannel, loadMessages]);
|
|
|
|
// Auto-select last visited (or first) channel when opening a server without a channelId
|
|
useEffect(() => {
|
|
if (!serverId || serverId === '@me' || channelId) return;
|
|
if (channels.length === 0) return;
|
|
|
|
const firstChannel = channels[0];
|
|
if (!firstChannel) return;
|
|
|
|
// Guard: only redirect when channels belong to the target server.
|
|
// `channels` is shared per-view state set by loadServerDetail (async).
|
|
// Without this check, stale channels from a previously viewed server
|
|
// would cause a wrong redirect during the fetch window.
|
|
const { channelToServerMap } = useServerStore.getState();
|
|
if (channelToServerMap.get(firstChannel.id) !== serverId) return;
|
|
|
|
const lastId = useUIStore.getState().lastChannelPerServer[serverId];
|
|
const target = (lastId && channels.find((c) => c.id === lastId)) || firstChannel;
|
|
if (target) {
|
|
navigate(`/channels/${serverId}/${target.id}`, { replace: true });
|
|
}
|
|
}, [serverId, channelId, channels, navigate]);
|
|
|
|
if (isLoading || !user) {
|
|
return (
|
|
<div className="h-screen flex items-center justify-center bg-surface-chat">
|
|
<div className="text-center">
|
|
<svg className="animate-spin w-10 h-10 text-accent-primary mx-auto mb-4" viewBox="0 0 24 24" fill="none">
|
|
<circle className="opacity-25" cx="12" cy="12" r="10" stroke="currentColor" strokeWidth="4" />
|
|
<path className="opacity-75" fill="currentColor" d="M4 12a8 8 0 018-8V0C5.373 0 0 5.373 0 12h4z" />
|
|
</svg>
|
|
<p className="text-txt-tertiary">Loading Backspace...</p>
|
|
</div>
|
|
</div>
|
|
);
|
|
}
|
|
|
|
return (
|
|
<div className="h-screen flex flex-col md:grid md:grid-cols-[312px_1fr] md:grid-rows-[minmax(0,1fr)] bg-surface-base overflow-hidden">
|
|
{/* Server sidebar - always visible on desktop, toggled on mobile */}
|
|
<div className={`fixed inset-y-0 left-0 z-40 flex w-[312px] transition-transform duration-200 ${sidebarOpen ? 'translate-x-0' : '-translate-x-full md:translate-x-0'} md:static md:z-auto md:w-auto md:transform-none`}>
|
|
<ServerSidebar />
|
|
<ChannelSidebar />
|
|
</div>
|
|
|
|
{/* Main content area */}
|
|
<div className="flex-1 flex min-w-0 min-h-0 bg-surface-chat relative">
|
|
<MainContent />
|
|
<RightPanel />
|
|
</div>
|
|
|
|
{/* Modals */}
|
|
<CreateServerModal />
|
|
<JoinServerModal />
|
|
<CreateChannelModal />
|
|
<InviteModal />
|
|
<UserSettingsModal />
|
|
<ServerSettingsModal />
|
|
<ChannelSettingsModal />
|
|
<NewDmModal />
|
|
<AddDmMemberModal />
|
|
<IncomingCallModal />
|
|
<ImagePreview />
|
|
<PictureInPicture />
|
|
<SoundController />
|
|
<GlobalAudioRenderer />
|
|
|
|
{/* User Profile Popout */}
|
|
{userProfilePopout.user && userProfilePopout.position && (
|
|
<>
|
|
<div
|
|
className="fixed inset-0 z-[145]"
|
|
onClick={closeUserProfile}
|
|
/>
|
|
<UserProfilePopout
|
|
user={userProfilePopout.user}
|
|
onClose={closeUserProfile}
|
|
position={userProfilePopout.position}
|
|
/>
|
|
</>
|
|
)}
|
|
|
|
{/* Federation toasts */}
|
|
<ToastContainer />
|
|
</div>
|
|
);
|
|
}
|