From da82ba6d94202b4c93f52689e85ce6cdf868e3fe Mon Sep 17 00:00:00 2001 From: Jannis Braun <151788261+TheZwiss@users.noreply.github.com> Date: Sat, 21 Mar 2026 23:43:00 +0100 Subject: [PATCH] fix: add key prop to RoleEditView to reset state when switching roles RoleEditView used useState(role.name) for draft state, but React reuses the component instance when editingRoleId changes, ignoring the new initial value. Adding key={editingRoleId} forces a remount, re-initializing all draft state (name, color, permissions) correctly. --- .../web/src/components/modals/spaceSettingsPanels/RolesPanel.tsx | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/web/src/components/modals/spaceSettingsPanels/RolesPanel.tsx b/packages/web/src/components/modals/spaceSettingsPanels/RolesPanel.tsx index d8525e8b..c943d1cd 100644 --- a/packages/web/src/components/modals/spaceSettingsPanels/RolesPanel.tsx +++ b/packages/web/src/components/modals/spaceSettingsPanels/RolesPanel.tsx @@ -112,6 +112,7 @@ export function RolesPanel({ spaceId }: RolesPanelProps) { } return ( setEditingRoleId(null)}