fix: replace inline save banners with toast notifications

This commit is contained in:
Jannis Braun
2026-03-22 04:48:32 +01:00
parent 7ff8614127
commit ca5cf61e53
5 changed files with 15 additions and 37 deletions
@@ -47,7 +47,6 @@ export function OverviewPanel({ spaceId }: OverviewPanelProps) {
const [saving, setSaving] = useState(false);
const [saveError, setSaveError] = useState('');
const [saveSuccess, setSaveSuccess] = useState(false);
const [confirmDelete, setConfirmDelete] = useState(false);
const fileInputRef = useRef<HTMLInputElement>(null);
@@ -174,7 +173,6 @@ export function OverviewPanel({ spaceId }: OverviewPanelProps) {
const handleSave = async () => {
setSaving(true);
setSaveError('');
setSaveSuccess(false);
try {
const updates: { name?: string; icon?: string; banner?: string; avatarColor?: string } = {};
if (hasNameChange) updates.name = spaceName.trim();
@@ -198,8 +196,7 @@ export function OverviewPanel({ spaceId }: OverviewPanelProps) {
URL.revokeObjectURL(bannerPreview);
setBannerPreview(null);
}
setSaveSuccess(true);
setTimeout(() => setSaveSuccess(false), 2000);
addToast('Settings saved', 'success', 2000);
} catch (err) {
setSaveError(err instanceof Error ? err.message : 'Failed to save');
} finally {
@@ -449,9 +446,6 @@ export function OverviewPanel({ spaceId }: OverviewPanelProps) {
{saveError && (
<div className="p-2 bg-accent-rose/10 border border-accent-rose/30 rounded text-txt-danger text-sm">{saveError}</div>
)}
{saveSuccess && (
<div className="p-2 bg-status-online/10 border border-status-online/30 rounded text-status-online text-sm">Settings saved</div>
)}
{/* Danger Zone */}
{isOwner && (
<div>
@@ -1,5 +1,6 @@
import React, { useState, useRef, useEffect } from 'react';
import { useSpaceStore } from '../../../stores/spaceStore';
import { useUIStore } from '../../../stores/uiStore';
import { api } from '../../../api/client';
import { PermissionBits, stringToPermissions, permissionsToString } from '../../../utils/permissions';
import type { Role } from '@backspace/shared';
@@ -227,10 +228,10 @@ function RoleEditView({ role, spaceId, isNew, onBack, onDeleted, onCopied }: Rol
const [draftPermissions, setDraftPermissions] = useState<bigint>(
stringToPermissions(role.permissions)
);
const addToast = useUIStore((s) => s.addToast);
const [saving, setSaving] = useState(false);
const [deleting, setDeleting] = useState(false);
const [saveError, setSaveError] = useState('');
const [saveSuccess, setSaveSuccess] = useState(false);
const [confirmDelete, setConfirmDelete] = useState(false);
const hasNameChange = !isEveryone && draftName.trim() !== role.name;
@@ -246,7 +247,6 @@ function RoleEditView({ role, spaceId, isNew, onBack, onDeleted, onCopied }: Rol
setConfirmDelete(false);
setSaving(true);
setSaveError('');
setSaveSuccess(false);
try {
const data: { name?: string; color?: string; permissions?: string } = {};
if (hasNameChange) data.name = draftName.trim();
@@ -254,8 +254,7 @@ function RoleEditView({ role, spaceId, isNew, onBack, onDeleted, onCopied }: Rol
if (hasPermChange) data.permissions = permissionsToString(draftPermissions);
await api.roles.update(spaceId, role.id, data);
await loadSpaceDetail(spaceId);
setSaveSuccess(true);
setTimeout(() => setSaveSuccess(false), 2000);
addToast('Role saved', 'success', 2000);
} catch (err) {
const msg = err instanceof Error ? err.message : 'Failed to save role';
if (msg.includes('already exists')) {
@@ -451,9 +450,6 @@ function RoleEditView({ role, spaceId, isNew, onBack, onDeleted, onCopied }: Rol
{saveError && (
<div className="p-2 bg-accent-rose/10 border border-accent-rose/30 rounded text-txt-danger text-sm">{saveError}</div>
)}
{saveSuccess && (
<div className="p-2 bg-status-online/10 border border-status-online/30 rounded text-status-online text-sm">Role saved</div>
)}
<div className="sticky bottom-0 z-10 pointer-events-none">
<div className="flex justify-center pt-3 pb-1">
<div className={`glass-bubble rounded-full px-4 py-2 flex items-center gap-2 pointer-events-auto${