devsyncwrld/backspace
1
0
Fork 0
Code Issues Pull Requests Actions 26 Packages Projects Releases Wiki Activity

fix: acceptor sets activeDmCall in click handler, not server response

Browse Source 
Bug A: handleAccept relied on dm_call_accepted server response to set
activeDmCall. But connectFn's async AudioContext resume yields to the
event loop, dm_call_accepted arrives during the yield, finds
isLiveKitConnected=false (connectFn just reset it), and skips
setActiveDmCall. The acceptor connects to LiveKit but the UI never
shows the call. Fix: set activeDmCall and clear incomingCall
directly in the click handler.

Bug B: ready handler no longer sets activeDmCall for active calls.
On refresh/restart the client has no LiveKit connection — showing
"Connecting..." with no connection is broken. The call exists on
the server but this client session is disconnected.
This commit is contained in:
Jannis Braun
2026-04-08 14:23:41 +02:00
parent aae0b1a74e
commit c037803c5a
2 changed files with 14 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/src/hooks/useWebSocket.ts
+4 -13
View File
@@ -321,21 +321,12 @@ function handleEvent(origin: string, event: ServerEvent): void {
// For federated calls, check membership via token presence (participants may be empty)
const isParticipant = call.participants.includes(myId) || !!call.livekitToken;
if (call.state === 'active' && isParticipant) {
const callDmId = call.dmChannelId || call.federatedCallId || '';
// Clear any stuck ringing UI from a ringing→active transition during refresh
setIncomingCall(null);
setActiveDmCall({ dmChannelId: callDmId });
// Store federated call data if present (server already filtered to this user's token)
if (call.livekitUrl && call.livekitToken) {
setFederatedCallData(call.livekitToken, call.livekitUrl);
}
if (call.federatedCallId) {
setFederatedCallId(call.federatedCallId);
}
// PASSIVE: do NOT auto-connect to LiveKit on ready.
// The user must click "Join" or re-accept. Auto-connecting causes
// identity conflicts when the same user has multiple sessions —
// both sessions fight for the same LiveKit identity slot.
// Do NOT set activeDmCall or auto-connect. On refresh/restart, the user
// is no longer in LiveKit — showing "Connecting..." with no connection
// is broken UX. The call exists on the server but this client session
// has no active LiveKit connection. The user can re-initiate if needed.
break;
} else if (call.state === 'ringing' && call.callerId !== myId) {
const dmCh = event.dmChannels?.find((d: any) => d.id === call.dmChannelId);