devsyncwrld/backspace
1
0
Fork 0
Code Issues Pull Requests Actions 26 Packages Projects Releases Wiki Activity

chore(friends): tighten Direct-Add gate consistency

Browse Source 
Per code-review: directAddDisplay now reads directAt === -1
instead of re-deriving includes('@'); add a one-line comment on
showDirectAdd so the predicate's intent is obvious at first read.
This commit is contained in:
Jannis Braun
2026-04-25 19:34:29 +02:00
parent da98d78489
commit 92a8a6a727
1 changed files with 4 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/src/components/chat/FriendsPage.tsx
+4 -3
View File
@@ -464,13 +464,14 @@ function AddFriendTab({
const trimmedQuery = query.trim(); const trimmedQuery = query.trim();
const directAt = trimmedQuery.lastIndexOf('@'); const directAt = trimmedQuery.lastIndexOf('@');
// Allow bare handle (no @) or @ at non-edge position; hide @, @bob, bob@.
const showDirectAdd = trimmedQuery.length > 0 const showDirectAdd = trimmedQuery.length > 0
&& (directAt === -1 || (directAt > 0 && directAt < trimmedQuery.length - 1)); && (directAt === -1 || (directAt > 0 && directAt < trimmedQuery.length - 1));
// Bare handle gets the home host appended for display only — submission // Bare handle gets the home host appended for display only — submission
// still uses the raw trimmed query. // still uses the raw trimmed query.
const directAddDisplay = trimmedQuery.includes('@') const directAddDisplay = directAt === -1
? trimmedQuery ? `${trimmedQuery}@${window.location.host}`
: `${trimmedQuery}@${window.location.host}`; : trimmedQuery;
// Direct Add handler // Direct Add handler
const handleDirectAdd = async () => { const handleDirectAdd = async () => {