devsyncwrld/backspace
1
0
Fork 0
Code Issues Pull Requests Actions 40 Packages Projects Releases 1 Wiki Activity

fix: cross-instance event contamination in federated DM calls

Browse Source 
Root cause: sendToFederatedCallUsers used sendToDmMembers when dmChannelId
was set, which broadcast to ALL DM members including the caller's replicated
stub. The caller's multi-instance WS received dm_call_accepted with the
REMOTE instance's dmChannelId, causing token request for a non-existent
channel (403) and preventing the caller from connecting.

Fix 1: sendToFederatedCallUsers always uses ringedUserIds (exact recipients)
instead of sendToDmMembers (all members including caller stub).

Fix 2: dm_call_accepted handler only sets activeDmCall if the client is the
caller (wasOutgoingCall) or already connected to LiveKit. Other instances of
the same user just clear ringing without entering stuck "Connecting..." state.
This commit is contained in:
Jannis Braun
2026-04-08 13:50:25 +02:00
parent 94461f8967
commit 86fe713a7c
2 changed files with 15 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/src/hooks/useWebSocket.ts
+9 -5
View File
@@ -802,15 +802,19 @@ function handleEvent(origin: string, event: ServerEvent): void {
case 'dm_call_accepted': {
const { setIncomingCall, setOutgoingCall, outgoingCall, setActiveDmCall, connectFn, isLiveKitConnected } = useVoiceStore.getState();
// Track whether WE are the caller before clearing state
const wasOutgoingCall = !!outgoingCall;
setIncomingCall(null);
setOutgoingCall(null);
// Only enter active call state if:
// - We're the caller (wasOutgoingCall) → will connect via connectFn below
// - We already connected to LiveKit (clicked accept in handleAccept)
// Other instances of the same user must NOT enter call state — they'd show
// "Connecting..." forever with no actual LiveKit connection.
const callDmId = event.dmChannelId || event.federatedCallId || '';
setActiveDmCall({ dmChannelId: callDmId });
// Only auto-connect if we're the CALLER waiting for acceptance.
// The callee who accepted connects in the click handler (handleAccept).
// Other instances of the same user should NOT auto-connect.
if (wasOutgoingCall || isLiveKitConnected) {
setActiveDmCall({ dmChannelId: callDmId });
}
if (connectFn && !isLiveKitConnected && wasOutgoingCall && callDmId) {
connectFn(callDmId, true).catch((err: unknown) => {
console.error('[WS] DM call connect failed:', err);