fix(permissions): deny space permissions to non-members (invite-bypass)
computePermissions() returned the space @everyone role's permissions without verifying the caller had joined the space. Because CREATE_INVITE is in DEFAULT_EVERYONE_PERMISSIONS, any authenticated user could mint an invite code for a request-only space — whose id is listed by /api/spaces/explore — and then self-join via /api/spaces/:id/join, bypassing the join-request approval flow. The same gap let non-members read message history and search default channels. Root cause: - computePermissions now returns 0n for non-members (space owner and instance admin still short-circuit first, so they are unaffected). Defense in depth (request-only spaces are approval-gated, never invite-joinable): - both invite-code join endpoints reject visibility='request' (private stays invite-joinable — its only entry path; public too). - POST /api/spaces/:id/invite refuses to hand out a code for request spaces. - POST /api/dm/space-invite refuses to card a local request space, checked by space id against the local table so a spoofed spaceInstanceOrigin can't slip past it. - InviteModal hides the invite affordances for request spaces. Also removes the unused computeCategoryPermissions(), which duplicated the resolution algorithm without the membership gate. Adds unit + route + component tests covering non-member/member/owner/admin resolution and the request/private/public visibility matrix. Reported-by: BadAtCaptchas (#2)
This commit is contained in:
@@ -2393,6 +2393,19 @@ export async function dmRoutes(app: FastifyInstance): Promise<void> {
|
||||
return reply.code(400).send({ error: 'invite_invalid', statusCode: 400 });
|
||||
}
|
||||
|
||||
// Request-only spaces are approval-gated and have no usable invite links, so
|
||||
// refuse to send an invite card that would dead-end at the recipient's join
|
||||
// guard. This is checked against our LOCAL spaces table by id, independent of
|
||||
// the caller-supplied spaceInstanceOrigin: if the space is genuinely local and
|
||||
// request-only we reject even when the origin is spoofed to look remote. A
|
||||
// truly remote space is absent from this table (undefined → allowed); its own
|
||||
// home instance enforces the same rule when the recipient tries to join.
|
||||
const localSpace = db.select({ visibility: schema.spaces.visibility })
|
||||
.from(schema.spaces).where(eq(schema.spaces.id, body.spaceId)).get();
|
||||
if (localSpace?.visibility === 'request') {
|
||||
return reply.code(403).send({ error: 'space_requires_approval', statusCode: 403 });
|
||||
}
|
||||
|
||||
// 4. Resolve / create the 1-on-1 DM (delegate to dedup helper).
|
||||
const dmChannelId = ensureOneOnOneDmChannel(callerId, targetUser, db);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user