fix(permissions): deny space permissions to non-members (invite-bypass)
computePermissions() returned the space @everyone role's permissions without verifying the caller had joined the space. Because CREATE_INVITE is in DEFAULT_EVERYONE_PERMISSIONS, any authenticated user could mint an invite code for a request-only space — whose id is listed by /api/spaces/explore — and then self-join via /api/spaces/:id/join, bypassing the join-request approval flow. The same gap let non-members read message history and search default channels. Root cause: - computePermissions now returns 0n for non-members (space owner and instance admin still short-circuit first, so they are unaffected). Defense in depth (request-only spaces are approval-gated, never invite-joinable): - both invite-code join endpoints reject visibility='request' (private stays invite-joinable — its only entry path; public too). - POST /api/spaces/:id/invite refuses to hand out a code for request spaces. - POST /api/dm/space-invite refuses to card a local request space, checked by space id against the local table so a spoofed spaceInstanceOrigin can't slip past it. - InviteModal hides the invite affordances for request spaces. Also removes the unused computeCategoryPermissions(), which duplicated the resolution algorithm without the membership gate. Adds unit + route + component tests covering non-member/member/owner/admin resolution and the request/private/public visibility matrix. Reported-by: BadAtCaptchas (#2)
This commit is contained in:
@@ -45,6 +45,15 @@ Storage: Bigint decimal strings in SQLite TEXT columns (bigint not JSON-safe).
|
||||
### Step 1: Owner/Admin Check
|
||||
- Space owner OR instance admin (`isAdmin === 1`) → return ALL_PERMISSIONS
|
||||
|
||||
### Step 1b: Membership Gate
|
||||
- If the user is **not** a member of the space (`getMember` returns nothing) → return `0n`
|
||||
- A non-member has no permissions in a space they have not joined. Without this,
|
||||
the @everyone role in Step 2 would leak default member rights (VIEW_CHANNEL,
|
||||
READ_MESSAGE_HISTORY, CREATE_INVITE, …) to any authenticated non-member —
|
||||
allowing them to read channels and mint invite codes for spaces they never
|
||||
joined. Owner and instance admin are already resolved in Step 1, so they are
|
||||
unaffected.
|
||||
|
||||
### Step 2: Compute Base (space-level)
|
||||
- Start with @everyone role permissions (role where `id === spaceId`)
|
||||
- OR together all permissions from user's assigned roles
|
||||
@@ -89,7 +98,6 @@ if channelOverride: base = (base & ~deny) | allow
|
||||
| `permissionsToString(perms)` | Bigint → decimal string for JSON |
|
||||
| `stringToPermissions(str)` | Decimal string → bigint (supports legacy JSON array format) |
|
||||
| `computePermissions(userId, spaceId, channelId?)` | Full resolution algorithm |
|
||||
| `computeCategoryPermissions(userId, spaceId, categoryId)` | Stops at category level (no channel overrides) |
|
||||
| `hasPermission(userId, spaceId, permission, channelId?)` | Boolean wrapper |
|
||||
| `getMember/isMember/isSpaceOwner` | Membership checks |
|
||||
| `isDmMember/isBanned` | DM/ban checks |
|
||||
|
||||
Reference in New Issue
Block a user