devsyncwrld/backspace
1
0
Fork 0
Code Issues Pull Requests Actions 26 Packages Projects Releases Wiki Activity

fix(web): server-side DELETE for failed/discarded uploads (no janitor wait)

Browse Source
This commit is contained in:
Jannis Braun
2026-05-02 18:22:45 +02:00
parent dd91f5f349
commit 4e5a440176
3 changed files with 35 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/src/components/chat/Message.tsx
+8 -3
View File
@@ -542,11 +542,16 @@ export function Message({ message, isCompact, isFirstInGroup, previousMessageId
const transfers = useTransferStore.getState().transfers;
for (const tid of pending.transferIds) {
const t = transfers.get(tid);
if (t && (t.state === 'active' || t.state === 'paused' || t.state === 'queued')) {
if (!t) continue;
// Route anything with potential server-side state (active/paused/
// queued/failed) through abortUpload — it sends DELETE so the
// .tus session doesn't sit on disk for the janitor to sweep.
// 'aborted' already cleaned itself; 'completed' has a finalized
// attachment row that the unlinked-attachment janitor handles (1h grace).
if (t.state !== 'aborted' && t.state !== 'completed') {
useTransferStore.getState().abortUpload(tid);
} else {
useTransferStore.getState().remove(tid);
}
useTransferStore.getState().remove(tid);
}
if (channelKey) {
usePendingMessageStore.getState().removeByClientId(channelKey, pending.clientId);
packages/web/src/components/chat/MessageInput.tsx
+9 -7
View File
@@ -253,15 +253,17 @@ export function MessageInput({ channelId, channelName }: MessageInputProps) {
const t = useTransferStore.getState().transfers.get(transferId);
if (t?.state === 'completed') {
// User is discarding a fully-uploaded attachment. Drop it entirely so
// no orphan 'aborted'-with-attachmentId record persists. Server-side
// bytes get cleaned by the storage janitor (per docs/systems/uploads.md).
// Fully-uploaded attachment with a finalized DB row. Server-side bytes
// get cleaned by the unlinked-attachment janitor (1h grace).
useTransferStore.getState().remove(transferId);
} else if (t && t.state !== 'aborted') {
// active/paused/queued/failed: abortUpload tears down any live tus
// instance AND sends DELETE for orphaned server-side .tus sessions.
// Then drop the transfer + free the retained File reference.
abortUpload(transferId);
useTransferStore.getState().remove(transferId);
} else {
// Tear down the live tus instance, then drop the transfer + free the
// retained File reference. (abortUpload alone leaves the record in the
// store for retry-after-abort; here the user is fully discarding.)
abortUpload(transferId);
// Already 'aborted' (server already cleaned); just drop the record.
useTransferStore.getState().remove(transferId);
}
removeStaged(channelId, transferId);