fix: harden data integrity, connection stability, and memory management

Wrap all multi-write DB operations in atomic transactions (server/channel creation, message+attachment linking, DM creation, friend acceptance, cascading deletes) to prevent partial-write corruption. Batch N+1 queries in WS ready payload into O(1) bulk fetches with chunked inArray() to respect SQLite's variable limit. Fix chat history regression where background WS messages bypassed channel load by switching the guard from messages.has() to hasMore.has(). Add LRU channel eviction (20 cached, evict to 15) and per-channel message cap (200) to bound client memory growth. Shorten WS heartbeat from 30s to 15s for aggressive proxy/NAT environments. Clear all user-scoped stores on logout to prevent cross-session data leaks. Extract LiveKit internal accessors into shared livekitInternals utility.
2026-02-24 03:52:22 +01:00
parent 2342396fce
commit 36e27121da
13 changed files with 380 additions and 205 deletions
@@ -374,24 +374,26 @@ export async function dmRoutes(app: FastifyInstance): Promise<void> {
      }
    }

-    // Create new DM channel
+    // Create new DM channel with both members atomically
    const dmChannelId = generateSnowflake();
    const now = Date.now();

-    db.insert(schema.dmChannels).values({
-      id: dmChannelId,
-      createdAt: now,
-    }).run();
+    db.transaction((tx) => {
+      tx.insert(schema.dmChannels).values({
+        id: dmChannelId,
+        createdAt: now,
+      }).run();

-    db.insert(schema.dmMembers).values({
-      dmChannelId,
-      userId: request.userId,
-    }).run();
+      tx.insert(schema.dmMembers).values({
+        dmChannelId,
+        userId: request.userId,
+      }).run();

-    db.insert(schema.dmMembers).values({
-      dmChannelId,
-      userId,
-    }).run();
+      tx.insert(schema.dmMembers).values({
+        dmChannelId,
+        userId,
+      }).run();
+    });

    const currentUserRow = db.select().from(schema.users).where(eq(schema.users.id, request.userId)).get();
    const members = [currentUserRow, targetUser]
@@ -791,24 +793,26 @@ export async function dmRoutes(app: FastifyInstance): Promise<void> {
    const messageId = generateSnowflake();
    const now = Date.now();

-    db.insert(schema.dmMessages).values({
-      id: messageId,
-      dmChannelId: id,
-      userId: request.userId,
-      replyToId: replyToId || null,
-      content: content?.trim() || null,
-      createdAt: now,
-    }).run();
+    // Insert message and link attachments atomically
+    db.transaction((tx) => {
+      tx.insert(schema.dmMessages).values({
+        id: messageId,
+        dmChannelId: id,
+        userId: request.userId,
+        replyToId: replyToId || null,
+        content: content?.trim() || null,
+        createdAt: now,
+      }).run();

-    // Link attachments to this DM message
-    if (attachmentIds && attachmentIds.length > 0) {
-      for (const attId of attachmentIds) {
-        db.update(schema.attachments)
-          .set({ dmMessageId: messageId })
-          .where(eq(schema.attachments.id, attId))
-          .run();
+      if (attachmentIds && attachmentIds.length > 0) {
+        for (const attId of attachmentIds) {
+          tx.update(schema.attachments)
+            .set({ dmMessageId: messageId })
+            .where(eq(schema.attachments.id, attId))
+            .run();
+        }
      }
-    }
+    });

    const message = getDmMessageWithUser(messageId);
    if (!message) {
@@ -886,20 +890,20 @@ export async function dmRoutes(app: FastifyInstance): Promise<void> {
      return reply.code(403).send({ error: 'You can only delete your own messages', statusCode: 403 });
    }

-    // Delete attachments linked to this DM message
-    db.delete(schema.attachments)
-      .where(eq(schema.attachments.dmMessageId, id))
-      .run();
+    // Delete attachments, reactions, and message atomically
+    db.transaction((tx) => {
+      tx.delete(schema.attachments)
+        .where(eq(schema.attachments.dmMessageId, id))
+        .run();

-    // Delete reactions
-    db.delete(schema.dmReactions)
-      .where(eq(schema.dmReactions.dmMessageId, id))
-      .run();
+      tx.delete(schema.dmReactions)
+        .where(eq(schema.dmReactions.dmMessageId, id))
+        .run();

-    // Delete message
-    db.delete(schema.dmMessages)
-      .where(eq(schema.dmMessages.id, id))
-      .run();
+      tx.delete(schema.dmMessages)
+        .where(eq(schema.dmMessages.id, id))
+        .run();
+    });

    // Broadcast to all DM members
    const dmMembers = db.select()
@@ -274,24 +274,26 @@ export async function messageRoutes(app: FastifyInstance): Promise<void> {
    const messageId = generateSnowflake();
    const now = Date.now();

-    db.insert(schema.messages).values({
-      id: messageId,
-      channelId: id,
-      userId: request.userId,
-      replyToId: replyToId || null,
-      content: content?.trim() || null,
-      createdAt: now,
-    }).run();
+    // Insert message and link attachments atomically
+    db.transaction((tx) => {
+      tx.insert(schema.messages).values({
+        id: messageId,
+        channelId: id,
+        userId: request.userId,
+        replyToId: replyToId || null,
+        content: content?.trim() || null,
+        createdAt: now,
+      }).run();

-    // Link attachments to message
-    if (attachmentIds && attachmentIds.length > 0) {
-      for (const attId of attachmentIds) {
-        db.update(schema.attachments)
-          .set({ messageId })
-          .where(eq(schema.attachments.id, attId))
-          .run();
+      if (attachmentIds && attachmentIds.length > 0) {
+        for (const attId of attachmentIds) {
+          tx.update(schema.attachments)
+            .set({ messageId })
+            .where(eq(schema.attachments.id, attId))
+            .run();
+        }
      }
-    }
+    });

    const user = db.select().from(schema.users).where(eq(schema.users.id, request.userId)).get();
    if (!user) {
@@ -415,9 +417,11 @@ export async function messageRoutes(app: FastifyInstance): Promise<void> {
      return reply.code(403).send({ error: 'You cannot delete this message', statusCode: 403 });
    }

-    // Delete attachments then message
-    db.delete(schema.attachments).where(eq(schema.attachments.messageId, id)).run();
-    db.delete(schema.messages).where(eq(schema.messages.id, id)).run();
+    // Delete attachments and message atomically
+    db.transaction((tx) => {
+      tx.delete(schema.attachments).where(eq(schema.attachments.messageId, id)).run();
+      tx.delete(schema.messages).where(eq(schema.messages.id, id)).run();
+    });

    // Broadcast deletion
    connectionManager.sendToServer(serverId, {
@@ -80,33 +80,33 @@ export async function serverRoutes(app: FastifyInstance): Promise<void> {
    const now = Date.now();
    const inviteCode = generateInviteCode();

-    // Create the server
-    db.insert(schema.servers).values({
-      id: serverId,
-      name: trimmedName,
-      icon: icon ?? null,
-      ownerId: request.userId,
-      inviteCode,
-      createdAt: now,
-    }).run();
+    // Create server, owner membership, and default channel atomically
+    db.transaction((tx) => {
+      tx.insert(schema.servers).values({
+        id: serverId,
+        name: trimmedName,
+        icon: icon ?? null,
+        ownerId: request.userId,
+        inviteCode,
+        createdAt: now,
+      }).run();

-    // Add owner as member with 'owner' role
-    db.insert(schema.serverMembers).values({
-      serverId,
-      userId: request.userId,
-      role: 'owner',
-      joinedAt: now,
-    }).run();
+      tx.insert(schema.serverMembers).values({
+        serverId,
+        userId: request.userId,
+        role: 'owner',
+        joinedAt: now,
+      }).run();

-    // Create default #general text channel
-    db.insert(schema.channels).values({
-      id: channelId,
-      serverId,
-      name: 'general',
-      type: 'text',
-      position: 0,
-      createdAt: now,
-    }).run();
+      tx.insert(schema.channels).values({
+        id: channelId,
+        serverId,
+        name: 'general',
+        type: 'text',
+        position: 0,
+        createdAt: now,
+      }).run();
+    });

    const server = db.select().from(schema.servers).where(eq(schema.servers.id, serverId)).get();
    if (!server) {
@@ -302,10 +302,12 @@ export async function serverRoutes(app: FastifyInstance): Promise<void> {
      return reply.code(403).send({ error: 'Only the server owner can delete the server', statusCode: 403 });
    }

-    // Delete all channels (messages cascade), members, then server
-    db.delete(schema.channels).where(eq(schema.channels.serverId, id)).run();
-    db.delete(schema.serverMembers).where(eq(schema.serverMembers.serverId, id)).run();
-    db.delete(schema.servers).where(eq(schema.servers.id, id)).run();
+    // Delete all channels (messages cascade), members, then server atomically
+    db.transaction((tx) => {
+      tx.delete(schema.channels).where(eq(schema.channels.serverId, id)).run();
+      tx.delete(schema.serverMembers).where(eq(schema.serverMembers.serverId, id)).run();
+      tx.delete(schema.servers).where(eq(schema.servers.id, id)).run();
+    });

    return reply.code(200).send({ success: true });
  });
@@ -207,15 +207,22 @@ export async function socialRoutes(app: FastifyInstance): Promise<void> {
    }

    if (status === 'accepted') {
-      // Add to friends table
+      // Insert friend and update request status atomically
      const now = Date.now();
-      db.insert(schema.friends).values({
-        userId: friendRequest.fromId,
-        friendId: friendRequest.toId,
-        createdAt: now,
-      }).run();
+      db.transaction((tx) => {
+        tx.insert(schema.friends).values({
+          userId: friendRequest.fromId,
+          friendId: friendRequest.toId,
+          createdAt: now,
+        }).run();

-      // Get the accepting user's data for the WS event
+        tx.update(schema.friendRequests)
+          .set({ status })
+          .where(eq(schema.friendRequests.id, id))
+          .run();
+      });
+
+      // WS broadcast AFTER transaction commits
      const acceptingUser = db.select().from(schema.users).where(eq(schema.users.id, request.userId)).get();
      if (acceptingUser) {
        const friend: Friend = {
@@ -228,14 +235,14 @@ export async function socialRoutes(app: FastifyInstance): Promise<void> {
          requestId: id,
        });
      }
+    } else {
+      // For declined, just update the status (single write, no transaction needed)
+      db.update(schema.friendRequests)
+        .set({ status })
+        .where(eq(schema.friendRequests.id, id))
+        .run();
    }

-    // Update request status
-    db.update(schema.friendRequests)
-      .set({ status })
-      .where(eq(schema.friendRequests.id, id))
-      .run();
-
    return reply.code(200).send({ success: true });
  });

@@ -2,7 +2,7 @@ import type { FastifyInstance } from 'fastify';
 import type { WebSocket } from 'ws';
 import { verifyJwt } from '../utils/auth.js';
 import { getDb, schema } from '../db/index.js';
-import { eq, inArray, desc } from 'drizzle-orm';
+import { eq, inArray, desc, sql } from 'drizzle-orm';
 import { handleClientEvent } from './events.js';
 import type {
  User,
@@ -16,6 +16,19 @@ import type {
  ActiveCallInfo,
 } from '@opencord/shared';

+// SQLite's SQLITE_MAX_VARIABLE_NUMBER default is 999.
+// Chunk inArray() calls to stay safely under this limit.
+const BATCH_CHUNK_SIZE = 500;
+
+function batchInArray<TId, TResult>(ids: TId[], queryFn: (chunk: TId[]) => TResult[]): TResult[] {
+  if (ids.length <= BATCH_CHUNK_SIZE) return queryFn(ids);
+  const results: TResult[] = [];
+  for (let i = 0; i < ids.length; i += BATCH_CHUNK_SIZE) {
+    results.push(...queryFn(ids.slice(i, i + BATCH_CHUNK_SIZE)));
+  }
+  return results;
+}
+
 function sanitizeUser(row: typeof schema.users.$inferSelect): User {
  return {
    id: row.id,
@@ -495,11 +508,36 @@ function buildReadyPayload(userId: string): {
      .where(inArray(schema.servers.id, serverIds))
      .all();

+    // Batch: all channels for all servers (1 query instead of N)
+    const allChannels = batchInArray(
+      serverIds,
+      ids => db.select().from(schema.channels).where(inArray(schema.channels.serverId, ids)).all(),
+    );
+    const channelsByServer = new Map<string, (typeof allChannels)>();
+    for (const ch of allChannels) {
+      let arr = channelsByServer.get(ch.serverId);
+      if (!arr) { arr = []; channelsByServer.set(ch.serverId, arr); }
+      arr.push(ch);
+    }
+
+    // Batch: last message ID per channel (1 query instead of N×C)
+    const allChannelIds = allChannels.map(ch => ch.id);
+    const lastMsgMap = new Map<string, string>();
+    if (allChannelIds.length > 0) {
+      const lastMsgRows = batchInArray(
+        allChannelIds,
+        ids => db.select({
+          channelId: schema.messages.channelId,
+          lastId: sql<string>`max(${schema.messages.id})`,
+        }).from(schema.messages).where(inArray(schema.messages.channelId, ids)).groupBy(schema.messages.channelId).all(),
+      );
+      for (const row of lastMsgRows) {
+        if (row.lastId) lastMsgMap.set(row.channelId, row.lastId);
+      }
+    }
+
    for (const serverRow of serverRows) {
-      const channels = db.select()
-        .from(schema.channels)
-        .where(eq(schema.channels.serverId, serverRow.id))
-        .all();
+      const channels = channelsByServer.get(serverRow.id) ?? [];

      const roles = db.select()
        .from(schema.roles)
@@ -514,7 +552,7 @@ function buildReadyPayload(userId: string): {

      const memberUserIds = memberRows.map(m => m.userId);
      const users = memberUserIds.length > 0
-        ? db.select().from(schema.users).where(inArray(schema.users.id, memberUserIds)).all()
+        ? batchInArray(memberUserIds, ids => db.select().from(schema.users).where(inArray(schema.users.id, ids)).all())
        : [];
      const userMap = new Map(users.map(u => [u.id, u]));

@@ -562,24 +600,16 @@ function buildReadyPayload(userId: string): {
        ownerId: serverRow.ownerId,
        inviteCode: serverRow.inviteCode,
        createdAt: serverRow.createdAt,
-        channels: channels.map(ch => {
-          const lastMsg = db.select({ id: schema.messages.id })
-            .from(schema.messages)
-            .where(eq(schema.messages.channelId, ch.id))
-            .orderBy(desc(schema.messages.createdAt))
-            .limit(1)
-            .get();
-          return {
-            id: ch.id,
-            serverId: ch.serverId,
-            name: ch.name,
-            type: ch.type as Channel['type'],
-            topic: ch.topic,
-            position: ch.position ?? 0,
-            createdAt: ch.createdAt,
-            lastMessageId: lastMsg?.id ?? null,
-          };
-        }),
+        channels: channels.map(ch => ({
+          id: ch.id,
+          serverId: ch.serverId,
+          name: ch.name,
+          type: ch.type as Channel['type'],
+          topic: ch.topic,
+          position: ch.position ?? 0,
+          createdAt: ch.createdAt,
+          lastMessageId: lastMsgMap.get(ch.id) ?? null,
+        })),
        members,
        roles: roles.map(r => ({
          id: r.id,
@@ -602,47 +632,70 @@ function buildReadyPayload(userId: string): {
    .where(eq(schema.dmMembers.userId, userId))
    .all();

+  const dmChannelIds = dmMemberships.map(dm => dm.dmChannelId);
  const dmChannels: DmChannel[] = [];

-  for (const dm of dmMemberships) {
-    const dmChannel = db.select()
-      .from(schema.dmChannels)
-      .where(eq(schema.dmChannels.id, dm.dmChannelId))
-      .get();
+  if (dmChannelIds.length > 0) {
+    // Batch: all DM channels (1 query)
+    const allDmChannelRows = batchInArray(
+      dmChannelIds,
+      ids => db.select().from(schema.dmChannels).where(inArray(schema.dmChannels.id, ids)).all(),
+    );
+    const dmChannelMap = new Map(allDmChannelRows.map(c => [c.id, c]));

-    if (!dmChannel) continue;
+    // Batch: all DM members across all channels (1 query)
+    const allDmMemberRows = batchInArray(
+      dmChannelIds,
+      ids => db.select().from(schema.dmMembers).where(inArray(schema.dmMembers.dmChannelId, ids)).all(),
+    );

-    const dmMemberRows = db.select()
-      .from(schema.dmMembers)
-      .where(eq(schema.dmMembers.dmChannelId, dm.dmChannelId))
-      .all();
-
-    const dmMemberUserIds = dmMemberRows.map(m => m.userId);
-    const dmUsers = dmMemberUserIds.length > 0
-      ? db.select().from(schema.users).where(inArray(schema.users.id, dmMemberUserIds)).all()
+    // Batch: all unique users from DM members (1 query)
+    const allDmUserIds = [...new Set(allDmMemberRows.map(m => m.userId))];
+    const allDmUsers = allDmUserIds.length > 0
+      ? batchInArray(allDmUserIds, ids => db.select().from(schema.users).where(inArray(schema.users.id, ids)).all())
      : [];
+    const dmUserMap = new Map(allDmUsers.map(u => [u.id, u]));

-    // Get last message
-    const lastMessage = db.select()
-      .from(schema.dmMessages)
-      .where(eq(schema.dmMessages.dmChannelId, dm.dmChannelId))
-      .orderBy(schema.dmMessages.createdAt)
-      .all();
+    // Batch: last message per DM channel (1 query — fixes the full-table-scan bug)
+    const dmLastMsgIdRows = batchInArray(
+      dmChannelIds,
+      ids => db.select({
+        dmChannelId: schema.dmMessages.dmChannelId,
+        lastId: sql<string>`max(${schema.dmMessages.id})`,
+      }).from(schema.dmMessages).where(inArray(schema.dmMessages.dmChannelId, ids)).groupBy(schema.dmMessages.dmChannelId).all(),
+    );
+    const dmLastMsgIds = dmLastMsgIdRows.map(r => r.lastId).filter((id): id is string => id != null);
+    const dmLastMessages = dmLastMsgIds.length > 0
+      ? batchInArray(dmLastMsgIds, ids => db.select().from(schema.dmMessages).where(inArray(schema.dmMessages.id, ids)).all())
+      : [];
+    const dmLastMsgMap = new Map(dmLastMessages.map(m => [m.dmChannelId, m]));

-    const last = lastMessage.length > 0 ? lastMessage[lastMessage.length - 1] : null;
+    // Assemble DM channels with zero additional queries
+    for (const dm of dmMemberships) {
+      const dmChannel = dmChannelMap.get(dm.dmChannelId);
+      if (!dmChannel) continue;

-    dmChannels.push({
-      id: dmChannel.id,
-      createdAt: dmChannel.createdAt,
-      members: dmUsers.map(sanitizeUser),
-      lastMessage: last ? {
-        id: last.id,
-        dmChannelId: last.dmChannelId,
-        userId: last.userId,
-        content: last.content,
-        createdAt: last.createdAt,
-      } : null,
-    });
+      const memberRows = allDmMemberRows.filter(m => m.dmChannelId === dm.dmChannelId);
+      const members = memberRows
+        .map(m => dmUserMap.get(m.userId))
+        .filter((u): u is NonNullable<typeof u> => u != null)
+        .map(sanitizeUser);
+
+      const last = dmLastMsgMap.get(dm.dmChannelId) ?? null;
+
+      dmChannels.push({
+        id: dmChannel.id,
+        createdAt: dmChannel.createdAt,
+        members,
+        lastMessage: last ? {
+          id: last.id,
+          dmChannelId: last.dmChannelId,
+          userId: last.userId,
+          content: last.content,
+          createdAt: last.createdAt,
+        } : null,
+      });
+    }
  }

  // Get Server Folders