devsyncwrld/backspace
1
0
Fork 0
Code Issues Pull Requests Actions 26 Packages Projects Releases Wiki Activity

fix: handle legacy JSON array permissions and improve admin toggle UX

Browse Source 
- Add migration to convert legacy JSON array permissions to decimal strings
- Add runtime fallback in stringToPermissions for legacy format
- Show all permission toggles as enabled (dimmed) when Administrator is on
This commit is contained in:
Jannis Braun
2026-03-09 23:01:27 +01:00
parent 11a69fe92a
commit 018828575c
3 changed files with 57 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/web/src/components/modals/spaceSettingsPanels/RolesPanel.tsx
+12 -8
View File
@@ -330,24 +330,28 @@ function RoleEditView({ role, spaceId, onBack, onDeleted }: RoleEditViewProps) {
<div className="rounded-lg bg-white/[0.02] p-3.5">
<div className="space-y-1">
{group.perms.map((perm) => {
const isOn = (draftPermissions & perm.bit) !== 0n;
const isAdmin = perm.bit === PermissionBits.ADMINISTRATOR;
const isAdminBit = perm.bit === PermissionBits.ADMINISTRATOR;
const hasAdmin = (draftPermissions & PermissionBits.ADMINISTRATOR) !== 0n;
const isOn = isAdminBit ? hasAdmin : hasAdmin || (draftPermissions & perm.bit) !== 0n;
const isInherited = !isAdminBit && hasAdmin;
return (
<label
key={perm.label}
className="flex items-center justify-between py-1.5 px-2 rounded hover:bg-interactive-hover cursor-pointer group/perm"
className={`flex items-center justify-between py-1.5 px-2 rounded cursor-pointer group/perm ${
isInherited ? 'opacity-50 cursor-default' : 'hover:bg-interactive-hover'
}`}
>
<span className={`text-sm ${isAdmin ? 'text-txt-danger font-medium' : 'text-txt-primary'}`}>
<span className={`text-sm ${isAdminBit ? 'text-txt-danger font-medium' : 'text-txt-primary'}`}>
{perm.label}
</span>
<div
onClick={(e) => {
e.preventDefault();
togglePermission(perm.bit);
if (!isInherited) togglePermission(perm.bit);
}}
className={`relative w-9 h-5 rounded-full transition-colors cursor-pointer ${
isOn ? 'bg-accent-primary' : 'bg-interactive-muted'
}`}
className={`relative w-9 h-5 rounded-full transition-colors ${
isInherited ? 'cursor-default' : 'cursor-pointer'
} ${isOn ? 'bg-accent-primary' : 'bg-interactive-muted'}`}
>
<div
className={`absolute top-0.5 w-4 h-4 rounded-full bg-white shadow-sm transition-transform ${